Select connector type before name #11388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area/frontend
area/platform
jamakase
approved these changes
Mar 24, 2022
| */ | ||
| const SetDefaultName: React.FC<{ | ||
| availableConnectors: ConnectorDefinition[]; | ||
| }> = ({ availableConnectors }) => { |
There was a problem hiding this comment.
Instead of passing availableConnectors and searching - you could use useServiceForm hook that has selectedService prop.
So this method will shorten to something like
const { selectedService } = useServiceForm();
const [,,helpers] = useField("name");
useEffect(() => {
const name = selectedService?.name ?? "";
helpers.setValue(name);
}, [selectedService, helpers]);
There was a problem hiding this comment.
Thanks, I will use useServiceForm here.
I tried using useField initially, but the problem is that the helpers it's returning isn't a stable reference, thus causing this useEffect to trigger in an endless loop, thus using the setFieldValue here instead (which is a stable reference).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Closes #11261
This will pull the connector type before the name box (and hide the name input as long as no connector is selected). It will also cause the name to become the connector definition name by default when it's switched.
Peek.2022-03-24.12-18.mp4